DOC update related packages #26922
Merged
DOC update related packages #26922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Jul 28, 2023
doc/related_projects.rst
Outdated
Comment on lines
211
to
212
| - `Keras <https://www.tensorflow.org/api_docs/python/tf/keras>`_ High-level API for | ||
| TensorFlow with a scikit-learn inspired API. |
There was a problem hiding this comment.
this should be replaced with scikeras: https://github.com/adriangb/scikeras
There was a problem hiding this comment.
scikeras come at line 217.
From what I read in https://www.tensorflow.org/api_docs/python/tf/keras/Model, it seems fine to keep this entry. But no strong feeling.
There was a problem hiding this comment.
Keras has a scikit-learn inspired API, but it does not really work well with our meta-estimators. I am +1 on removing the Keras entry.
thomasjpfan
approved these changes
Jul 28, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #26906.
What does this implement/fix? Explain your changes.
Any other comments?