8000 MNT Improve robustness of sparse test in `HDBSCAN` by Micky774 · Pull Request #26889 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT Improve robustness of sparse test in HDBSCAN #26889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 27, 2023
Merged

MNT Improve robustness of sparse test in HDBSCAN #26889

merged 6 commits into from
Jul 27, 2023

Conversation

Micky774
Copy link
Contributor

Reference Issues/PRs

Towards #26801

What does this implement/fix? Explain your changes.

In pursuit of another feature enhancement, I noticed that the tests were missing certain cases and could be made more robust

Any other comments?

@Micky774 Micky774 mentioned this pull request Jul 24, 2023
Open
13 tasks
@github-actions
Copy link
github-actions bot commented Jul 24, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 15f2f1c. Link to the linter CI: here

@Micky774 Micky774 marked this pull request as ready for review July 24, 2023 17:36
thomasjpfan
thomasjpfan approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@Micky774 @thomasjpfan
Update sklearn/cluster/tests/test_hdbscan.py
941a6d8 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@Micky774 Micky774 added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! labels Jul 26, 2023
OmarManzoor
OmarManzoor approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Micky774

@OmarManzoor OmarManzoor merged commit e54f678 into scikit-learn:main Jul 27, 2023
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
@Micky774 @punndcoder28
MNT Improve robustness of sparse test in HDBSCAN (scikit-learn#26889)
640bfd5
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@Micky774 @glemaitre
MNT Improve robustness of sparse test in HDBSCAN (scikit-learn#26889)
2197a99
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@Micky774 @jeremiedbb
MNT Improve robustness of sparse test in HDBSCAN (#26889)
c7485e7
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Micky774 @REDVM
MNT Improve robustness of sparse test in HDBSCAN (scikit-learn#26889)
b9788b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:cluster No Changelog Needed Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Micky774 @thomasjpfan @OmarManzoor
0