8000 DOC: added dropdowns to module 1.9 naive bayes by MikiPWata · Pull Request #26819 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content
8000

DOC: added dropdowns to module 1.9 naive bayes #26819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2023
Merged

DOC: added dropdowns to module 1.9 naive bayes #26819

merged 3 commits into from
Nov 2, 2023

Conversation

MikiPWata
Copy link
Contributor

Reference Issues/PRs

add dropdowns to the module 1.9 Naive Bayes from Issue #26617

What does this implement/fix? Explain your changes.

Folded:

  • Weights forecalculation details in 1.9.3
  • Probability calculation details in 1.9.5

Any other comments?

@github-actions
Copy link
github-actions bot commented Jul 11, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2100e22. Link to the linter CI: here

@ArturoAmorQ ArturoAmorQ mentioned this pull request Jul 12, 2023
Closed
54 tasks
ArturoAmorQ
ArturoAmorQ approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member
@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this small comment, LGTM :)

doc/modules/naive_bayes.rst Outdated
by a considerable margin) on text classification tasks.

|details-start|
**Weights forecalculation**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this word is a bit unknown to non-native speakers. I would rather simply say "calculation".

Suggested change
**Weights forecalculation**
**Weights calculation**

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah totally agree, thanks!
let me change that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done fixing!

@MikiPWata MikiPWata force-pushed the feature/DOC-add_dropdown_naive_bayes-26617 branch from ac70f67 to be3fbde Compare July 25, 2023 01:56
@MikiPWata MikiPWata requested a review from ArturoAmorQ July 25, 2023 01:56
@MikiPWata MikiPWata force-pushed the feature/DOC-add_dropdown_naive_bayes-26617 branch from be3fbde to 42160b8 Compare July 25, 2023 02:51
ArturoAmorQ
ArturoAmorQ approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member
@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the change. This PR LGTM in it's current state.

Just notice it is not a good practice to force push, as it makes more difficult the reviewing process.

@glemaitre glemaitre self-requested a review November 2, 2023 17:49
glemaitre
glemaitre approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly added dropdown menu for the references as well.
LGTM.
Thanks @MikiPWata

@glemaitre glemaitre merged commit ef39631 into scikit-learn:main Nov 2, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@MikiPWata @glemaitre @REDVM
DOC added dropdowns to module 1.9 naive bayes (scikit-learn#26819)
9a1b390 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikiPWata @glemaitre @ArturoAmorQ
0