DOC Added dropdowns to 6.2 feature-extraction #26807
Conversation
|
@betatim Hello, can you please help!, this is my first open source contribution :) |
There was a problem hiding this comment.
Thanks for the PR @Kishan-Ved!
I think this section can still make use of more dropdowns, e.g.:
- a dropdown for "using stop words" in 6.2.3.3
- a dropdown for "worked-out example" in 6.2.3.4
- a dropdown for "troubleshooting decoding text" in 6.2.3.5
- a dropdown for "tips and tricks" in 6.2.3.9
doc/modules/feature_extraction.rst
Outdated
| .. topic:: References: | ||
| * `MurmurHash3 <https://github.com/aappleby/smhasher>`_. |
There was a problem hiding this comment.
The reference is not being rendered because it needs an extra space:
| .. topic:: References: | |
| * `MurmurHash3 <https://github.com/aappleby/smhasher>`_. | |
| .. topic:: References: | |
| * `MurmurHash3 <https://github.com/aappleby/smhasher>`_. |
There was a problem hiding this comment.
I have fixed this, thank you. I have also added the 4 dropdowns that you have mentioned, please review the PR for a merge.
Updated based on the review by @ArturoAmorQ. Added: - A dropdown for "using stop words" in 6.2.3.3 - A dropdown for "worked-out example" in 6.2.3.4 - A dropdown for "troubleshooting decoding text" in 6.2.3.5 - A dropdown for "tips and tricks" in 6.2.3.9
doc/modules/feature_extraction.rst
Outdated
| @@ -490,6 +497,10 @@ class:: | |||
| Again please see the :ref:`reference documentation | |||
| <text_feature_extraction_ref>` for the details on all the parameters. | |||
|
|
|||
| |details-start| | |||
| Example | |||
There was a problem hiding this comment.
Maybe we can be a bit more explicit here:
| Example | |
| Numeric example of a tf-idf matrix |
There was a problem hiding this comment.
I've done it, thanks for the suggestion! Kindly check.
There was a problem hiding this comment.
Good to go? @ArturoAmorQ
Changed line 501
On my side, yes. We need another approval, though. |
According to the Decision making process I think we can consider this as a "minor documentation change" and should be good to go with my approval. Long story short, I am merging this one. Thanks again for your work and patience @Kishan-Ved :) |
Reference Issues/PRs
Add dropdowns to submodule 6.2 Feature Extraction regarding #26617.
Folded:
6.2.2.1. Implementation details (Cross referencing taken care of by adding it inside the dropdown)
6.2.3.9. Performing out-of-core scaling with HashingVectorizer
SIDE NOTE:
I am on summer vacation, I can work extensively on this and more contributions provided my PR is accepted, so I know I'm on the right track as this is my first time contributing to open source :) .