8000 [MRG] DOC Add docstring DistanceMetric class by greyisbetter · Pull Request #26795 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] DOC Add docstring DistanceMetric class #26795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 24, 2023
Merged

[MRG] DOC Add docstring DistanceMetric class #26795

merged 9 commits into from
Jul 24, 2023

Conversation

greyisbetter
Copy link
Contributor
@greyisbetter greyisbetter commented Jul 7, 2023 •
edited
Loading

Towards #26776

Add documentation for the public class DistanceMetric.

@github-actions
Copy link
github-actions bot commented Jul 7, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 89843a0. Link to the linter CI: here

glemaitre
glemaitre reviewed Jul 11, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are in a Cython file, I don't think we have a linter to avoid having more than 88 characters.

Could you ensure not to have more than 88 characters for all changes?

@greyisbetter
Copy link
Contributor Author

Thanks @glemaitre for the review. I updated each line to under 88 characters and the rest of the suggestions as well.

@greyisbetter greyisbetter requested a review from glemaitre July 13, 2023 09:07
OmarManzoor
OmarManzoor approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@greyisbetter greyisbetter changed the title DOC Add docstring DistanceMetric class [MRG] DOC Add docstring DistanceMetric class Jul 17, 2023
glemaitre
glemaitre approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering looks good. Merging.
Thanks @greyisbetter

@glemaitre glemaitre merged commit ca51d77 into scikit-learn:main Jul 24, 2023
@greyisbetter greyisbetter deleted the distancemetric-docs branch July 24, 2023 09:36
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
@greyisbetter @punndcoder28
DOC Add docstring DistanceMetric class (scikit-learn#26795)
7d07f87
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@greyisbetter @glemaitre
DOC Add docstring DistanceMetric class (scikit-learn#26795)
086082f
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@greyisbetter @jeremiedbb
DOC Add docstring DistanceMetric class (#26795)
60c5e76
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@greyisbetter @REDVM
DOC Add docstring DistanceMetric class (scikit-learn#26795)
7a58322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
cython Documentation module:metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greyisbetter @glemaitre @OmarManzoor
0