8000 MAINT solve the failure in scipy-dev by glemaitre · Pull Request #26646 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT solve the failure in scipy-dev #26646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 21, 2023
Merged

MAINT solve the failure in scipy-dev #26646

merged 8 commits into from
Jun 21, 2023

Conversation

glemaitre
Copy link
Member

Try to solve issue seen in the scipy-dev CI

@github-actions
Copy link
github-actions bot commented Jun 21, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b8f6667

@glemaitre
Copy link
Member Author

I assume that one of the failures is raised by the following change in NumPy:

@ogrisel ogrisel mentioned this pull request Jun 21, 2023
Closed
@ogrisel
Copy link
Member
ogrisel commented Jun 21, 2023

I reported the random numpy errstate regression upstream:

thomasjpfan
thomasjpfan reviewed Jun 21, 2023
View reviewed changes
glemaitre
glemaitre commented Jun 21, 2023
View reviewed changes
glemaitre
glemaitre commented Jun 21, 2023
View reviewed changes
glemaitre
glemaitre commented Jun 21, 2023
View reviewed changes
glemaitre
glemaitre commented Jun 21, 2023
View reviewed changes
glemaitre
glemaitre commented Jun 21, 2023
View reviewed changes
glemaitre
glemaitre commented Jun 21, 2023
View reviewed changes
thomasjpfan
thomasjpfan approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogrisel ogrisel merged commit 9ff86c6 into scikit-learn:main Jun 21, 2023
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jun 29, 2023
@glemaitre @jeremiedbb
MAINT solve the failure in scipy-dev (scikit-learn#26646)
cb2adfb
jeremiedbb pushed a commit that referenced this pull request Jun 29, 2023
@glemaitre @jeremiedbb
MAINT solve the failure in scipy-dev (#26646)
ab833e1
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@glemaitre @REDVM
MAINT solve the failure in scipy-dev (scikit-learn#26646)
f6119d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:linear_model No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glemaitre @ogrisel @thomasjpfan
0