DOC Fix typos in math in Target Encoder user guide #26584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyleeow
commented
Jun 15, 2023
| :math:`\sigma_i^2` is the variance of `y` with category :math:`i` and | ||
| :math:`\tau^2` is the global variance of `y`. | ||
|
|
||
| For continuous targets, the formulation is similar to binary classification: | ||
|
|
||
| .. math:: | ||
| S_i = \lambda_i\frac{\sum_{k\in L_i}y_k}{n_i} + (1 - \lambda_i)\frac{\sum_{k=1}^{n}y_k}{n} | ||
| S_i = \lambda_i\frac{\sum_{k\in L_i}Y_k}{n_i} + (1 - \lambda_i)\frac{\sum_{k=1}^{n}Y_k}{n} |
There was a problem hiding this comment.
This was more opinionated, but changed to capital Y to match the equation for binary case and the Micci-Barreca paper.
cc @thomasjpfan
thomasjpfan
approved these changes
Jun 15, 2023
glemaitre
reviewed
Jun 15, 2023
|
Thanks @lucyleeow LGTM. |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jun 29, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Jun 29, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Fixes some typos in the math equation in Target Encoder section of the user guide.
Any other comments?