8000 FIX Updated hdbscan stability calculation to avoid implicit casting by Micky774 · Pull Request #26546 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX Updated hdbscan stability calculation to avoid implicit casting #26546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2023
Merged

FIX Updated hdbscan stability calculation to avoid implicit casting #26546

merged 2 commits into from
Jun 9, 2023

Conversation

Micky774
Copy link
Contributor
@Micky774 Micky774 commented Jun 8, 2023

Reference Issues/PRs

Fixes #26535

What does this implement/fix? Explain your changes.

Updates the construction of the final stability dict to avoid implicit casting

Any other comments?

I'm not sure what exactly led to the change in behavior but most likely some update in Cython escalated the implicit cast to an error.

cc: @jeremiedbb @lesteve

jeremiedbb
jeremiedbb approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still many failures in the scipy-dev job but those are not related to hdbscan.

@lesteve
Copy link
Member
lesteve commented Jun 9, 2023

Merging, thanks a lot!

@lesteve lesteve merged commit 66733c4 into scikit-learn:main Jun 9, 2023
manudarmi pushed a commit to primait/scikit-learn that referenced this pull request Jun 12, 2023
@Micky774 @jeremiedbb @manudarmi
FIX Updated hdbscan stability calculation to avoid implicit casting (s…
3516728 
…cikit-learn#26546)

Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Micky774 @jeremiedbb @REDVM
FIX Updated hdbscan stability calculation to avoid implicit casting (s…
9c27f04 
…cikit-learn#26546)

Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
cython module:cluster No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HDBSCAN with cython development version yields TypeError: 'float' object cannot be interpreted as an integer
3 participants
@Micky774 @lesteve @jeremiedbb
0