[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH make fit_transform and fit_predict composite methods (SLEP6) #26506

Merged
merged 15 commits into from
Jun 21, 2023
Merged

ENH make fit_transform and fit_predict composite methods (SLEP6) #26506

merged 15 commits into from
Jun 21, 2023

Conversation

adrinjalali
Copy link
Member

Moving #24585 here to be merged to main.

This is specifically required for the work on Pipeline.

@adrinjalali adrinjalali mentioned this pull request Jun 3, 2023
Open
27 tasks
@adrinjalali
Copy link
Member Author

@glemaitre you already signed off on the original PR, so maybe you could do here too? 😁

@glemaitre
Copy link
Member

Promise I will give a review by tomorrow

@glemaitre glemaitre self-requested a review June 14, 2023 20:10
thomasjpfan
thomasjpfan reviewed Jun 19, 2023
View reviewed changes
sklearn/utils/_metadata_requests.py Outdated Show resolved Hide resolved
sklearn/tests/test_metadata_routing.py Outdated Show resolved Hide resolved
sklearn/tests/test_metadata_routing.py Outdated Show resolved Hide resolved
doc/whats_new/v1.3.rst Outdated Show resolved Hide resolved
thomasjpfan
thomasjpfan approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

glemaitre
glemaitre reviewed Jun 21, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks

doc/whats_new/v1.4.rst Outdated Show resolved Hide resolved
sklearn/tests/test_metadata_routing.py Show resolved Hide resolved
sklearn/tests/test_metadata_routing.py Outdated Show resolved Hide resolved
@github-actions
Copy link

Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

glemaitre
glemaitre approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promise I will give a review by tomorrow

Apparently I have no tomorrow ;)

@glemaitre glemaitre enabled auto-merge (squash) June 21, 2023 12:49
@glemaitre glemaitre merged commit 4163b32 into scikit-learn:main Jun 21, 2023
21 checks passed
@adrinjalali adrinjalali deleted the slep6/composit_method branch June 21, 2023 14:08
@adrinjalali adrinjalali mentioned this pull request Jun 21, 2023
Closed
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@adrinjalali @glemaitre @REDVM
ENH make fit_transform and fit_predict composite methods (SLEP6) (sci…
c3664db 
…kit-learn#26506)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrinjalali @glemaitre @thomasjpfan