-
-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH make fit_transform and fit_predict composite methods (SLEP6) #26506
ENH make fit_transform and fit_predict composite methods (SLEP6) #26506
Conversation
@glemaitre you already signed off on the original PR, so maybe you could do here too? 😁 |
Promise I will give a review by tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nitpicks
Linting PassedAll linting checks passed. Your pull request is in excellent shape! ☀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Promise I will give a review by tomorrow
Apparently I have no tomorrow ;)
…kit-learn#26506) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Moving #24585 here to be merged to
main
.This is specifically required for the work on
Pipeline
.