8000 STY Do not make whole space white in html repr by thomasjpfan · Pull Request #26485 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

STY Do not make whole space white in html repr #26485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

STY Do not make whole space white in html repr #26485

merged 1 commit into from
Jun 1, 2023

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Related to #26364

What does this implement/fix? Explain your changes.

Before this PR, with VScode notebooks the HTML repr will make the whole cell white:

Screenshot 2023-06-01 at 9 35 56 AM

With this PR only the HTML repr is white:

Screenshot 2023-06-01 at 9 35 43 AM

Any other comments?

I'm still thinking about how to enable dark mode based on OS preferences. According to jupyterlab/jupyterlab#8777, Jupyter does not currently support the prefers-color-scheme CSS media query.

@thomasjpfan thomasjpfan added the Quick Review For PRs that are quick to review label Jun 1, 2023
@betatim
Copy link
Member
betatim commented Jun 1, 2023

In principle fine with me. A bit hard to know what this could be breaking, but we can wait for bug reports if no one has an idea what else to test?

adrinjalali
adrinjalali approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good improvement. We shouldn't care much about people relying on the rendered version I think.

@betatim betatim merged commit 2953978 into scikit-learn:main Jun 1, 2023
manudarmi pushed a commit to primait/scikit-learn that referenced this pull request Jun 12, 2023
@thomasjpfan @manudarmi
STY Do not make whole space white in html repr (scikit-learn#26485)
1dffb86
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@thomasjpfan @REDVM
STY Do not make whole space white in html repr (scikit-learn#26485)
1622b65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
module:utils Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @betatim @adrinjalali
0