8000 CLN io.open() → open() by DimitriPapadopoulos · Pull Request #26449 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CLN io.open() → open() #26449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

CLN io.open() → open() #26449

merged 1 commit into from
May 30, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

In Python 3, io.open() is an alias for the builtin open() function:
https://docs.python.org/3/library/io.html#io.open

Any other comments?

@thomasjpfan thomasjpfan changed the title [MRG] io.open() → open() CLN io.open() → open() May 28, 2023
thomasjpfan
thomasjpfan approved these changes May 28, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @DimitriPapadopoulos ! I am okay with this adjustment. LGTM!

jeremiedbb
jeremiedbb approved these changes May 30, 2023
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DimitriPapadopoulos

@jeremiedbb jeremiedbb merged commit 1084860 into scikit-learn:main May 30, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the io.open branch May 30, 2023 14:37
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@DimitriPapadopoulos @REDVM
MAINT CLN io.open() → open() (scikit-learn#26449)
03b8151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitriPapadopoulos @thomasjpfan @jeremiedbb
0