10000 MAINT Clean-up deprecated wminkowski distance metric for 1.3 by jeremiedbb · Pull Request #26434 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Clean-up deprecated wminkowski distance metric for 1.3 #26434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2023
Merged

MAINT Clean-up deprecated wminkowski distance metric for 1.3 #26434

merged 4 commits into from
May 31, 2023

Conversation

jeremiedbb
Copy link
Member
@jeremiedbb jeremiedbb commented May 25, 2023 •
edited
Loading

The WMinkowskiDistance class was deprecated in 1.1.

KNN classes didn't properly deprecate metric="wminkowski" but there was the future warning for WMinkowskiDistance being deprecated so it's fine to just remove it.

However, metric="wminkowski" was not deprecated at all for pairwise_distances and co because it directly relies on the scipy function. That is, if you have an old version of scipy, metric="wminkowski" works, and if you have a recent version of scipy it doesn't. I left it as is. We could decide to deprecate it properly but I'd just let it and it'll settle automatically when we drop support for scipy < 1.8.

@jeremiedbb jeremiedbb added this to the 1.3 milestone May 25, 2023
thomasjpfan
thomasjpfan approved these changes May 25, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

glemaitre
glemaitre approved these changes May 31, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@glemaitre glemaitre merged commit fecfb34 into scikit-learn:main May 31, 2023
@glemaitre
Copy link
Member

Merging thanks @jeremiedbb

REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@jeremiedbb @REDVM
MAINT Clean-up deprecated wminkowski distance metric for 1.3 (scikit-…
e5f5168 
…learn#26434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
cython module:cluster module:metrics module:neighbors No Changelog Needed
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @glemaitre @thomasjpfan
0