8000 CI Do not upload to codecov on forks by thomasjpfan · Pull Request #26375 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

CI Do not upload to codecov on forks #26375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023

Conversation

thomasjpfan
Copy link
Member

This PR disables codecov uploads for forks. This is useful for testing the Azure CI on a fork.

@betatim
Copy link
Member
betatim commented May 16, 2023

Does this effect PRs from forks? As in, will this lead to it being as if codecov doesn't exist when someone opens a PR from a fork (or is it like that already)?

@glemaitre
Copy link
Member

Does this effect PRs from forks? As in, will this lead to it being as if codecov doesn't exist when someone opens a PR from a fork (or is it like that already)?

Since that codecov is shown in this PR then I assume that this is fine.

@betatim
Copy link
Member
betatim commented May 16, 2023

Maybe the if checks the name of the repository for which the CI is running, not the source of the PR.

@betatim betatim merged commit 4d07c80 into scikit-learn:main May 16, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0