8000 MAINT Update _kmeans.py warning message by hmaarrfk · Pull Request #26362 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Update _kmeans.py warning message #26362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2023
Merged

MAINT Update _kmeans.py warning message #26362

merged 1 commit into from
May 16, 2023

Conversation

hmaarrfk
Copy link
Contributor

Point it to the right stack level.

I hope this helps.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@betatim
Copy link
Member
betatim commented May 16, 2023

With main this is the warning I see:

/xxx/scikit-learn/sklearn/cluster/_kmeans.py:890: FutureWarning: The default value of `n_init` will change from 10 to 'auto' in 1.4. Set the value of `n_init` explicitly to suppress the warning
  warnings.warn(

with this PR I see the following:

/xxx/scikit-learn/sklearn/cluster/_kmeans.py:1420: FutureWarning: The default value of `n_init` will change from 10 to 'auto' in 1.4. Set the value of `n_init` explicitly to suppress the warning
  super()._check_params_vs_input(X, default_n_init=10)

I think this is an improvement.

thomasjpfan
thomasjpfan reviewed May 16, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan changed the title Update _kmeans.py warning message MAINT Update _kmeans.py warning message May 16, 2023
@thomasjpfan thomasjpfan merged commit a2b8571 into scikit-learn:main May 16, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@hmaarrfk @REDVM
MAINT Update _kmeans.py warning message (scikit-learn#26362)
bbf8736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmaarrfk @betatim @thomasjpfan
0