10000 DOC Add missing cross validation image alt by marekhanus · Pull Request #26261 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Add missing cross validation image alt #26261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

DOC Add missing cross validation image alt #26261

merged 1 commit into from
Jul 28, 2023

Conversation

marekhanus
Copy link
Contributor
@marekhanus marekhanus commented Apr 22, 2023 •
edited
Loading

Reference Issues/PRs

See also #21214.

What does this implement/fix? Explain your changes.

Any other comments?

@betatim
Copy link
Member
betatim commented Apr 24, 2023 •
edited
Loading

Thanks for taking the time to work on this. While looking at the alt text you added and reading the issue you linked I started thinking about "what makes a good alt text?". I found this comment and the one after it useful. As well as the content they link to.

Instead of repeating the name of the figure as the alt text I think having a short description a la http://diagramcenter.org/specific-guidelines-g.html#71 would be a good alt text. Describing the important parts that can be seen in the image. In this context I think "important" is about "what do I need to take away from this image to better understand the text?". What do you think @marekhanus ?

adrinjalali
adrinjalali reviewed Jul 27, 2023
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a better alt.

@github-actions
Copy link
github-actions bot commented Jul 28, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2a0cbe8. Link to the linter CI: here

@marekhanus marekhanus force-pushed the feature/cross_validation_alt branch from 52e9f6e to 2d84eb0 Compare July 28, 2023 07:13
@marekhanus
Copy link
Contributor Author

Sorry @betatim, I forgot to change it.

--

I think this should be a better alt.

Thanks @adrinjalali.

@marekhanus marekhanus force-pushed the feature/cross_validation_alt branch from 2d84eb0 to 754852e Compare July 28, 2023 07:28
@marekhanus @adrinjalali
DOC Add missing cross validation image alt
2a0cbe8 
Thanks @adrinjalali.

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@marekhanus marekhanus force-pushed the feature/cross_validation_alt branch from 754852e to 2a0cbe8 Compare July 28, 2023 07:31
@adrinjalali adrinjalali merged commit 1090121 into scikit-learn:main Jul 28, 2023
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
@marekhanus @adrinjalali @punndcoder28
DOC Add missing cross validation image alt (scikit-learn#26261)
23e3fd4 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@marekhanus @adrinjalali @glemaitre
DOC Add missing cross validation image alt (scikit-learn#26261)
64eeba3 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@marekhanus @adrinjalali @jeremiedbb
DOC Add missing cross validation image alt (#26261)
c3e49a9 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@marekhanus @adrinjalali @REDVM
DOC Add missing cross validation image alt (scikit-learn#26261)
1b06ec3 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marekhanus @betatim @adrinjalali
0