8000 MAINT Parameters validation for datasets.make_sparse_spd_matrix · Pull Request #26009 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Parameters validation for datasets.make_sparse_spd_matrix #26009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Mar 29, 2023
Merged

MAINT Parameters validation for datasets.make_sparse_spd_matrix #26009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2114525
MAINT Parameters validation for datasets.make_sparse_spd_matrix
Mar 28, 2023
86cc040
Merge branch 'main' into parameters_validation_make_sparse_spd_matrix
jeremiedbb Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sklearn/datasets/_samples_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,6 +1537,16 @@ def make_spd_matrix(n_dim, *, random_state=None):
return X


@validate_params(
{
"dim": [Interval(Integral, 1, None, closed="left")],
"alpha": [Interval(Real, 0, 1, closed="both")],
"norm_diag": ["boolean"],
"smallest_coef": [Interval(Real, 0, 1, closed="both")],
"largest_coef": [Interval(Real, 0, 1, closed=&qu B853 ot;both")],
"random_state": ["random_state"],
}
)
def make_sparse_spd_matrix(
dim=1,
*,
Expand Down
1 change: 1 addition & 0 deletions sklearn/tests/test_public_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ def _check_function_param_validation(
"sklearn.datasets.make_multilabel_classification",
"sklearn.datasets.make_regression",
"sklearn.datasets.make_sparse_coded_signal",
"sklearn.datasets.make_sparse_spd_matrix",
"sklearn.datasets.make_sparse_uncorrelated",
"sklearn.datasets.make_spd_matrix",
"sklearn.decomposition.sparse_encode",
Expand Down
0