E5C4 MAINT Replace cnp.ndarray with memory views in _hashing_fast.pyx by npache · Pull Request #25843 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Replace cnp.ndarray with memory views in _hashing_fast.pyx #25843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MAINT Replace cnp.ndarray with memory views in _hashing_fast.pyx #25843

wants to merge 1 commit into from

Conversation

npache
Copy link
Contributor
@npache npache commented Mar 13, 2023 •
edited by jjerphan
Loading

Reference Issues/PRs

Towards #25484

What does this implement/fix? Explain your changes.

Any other comments?

In this case I am not sure in how to make the change because the dtype is dynamical and it is in python format

@jjerphan
Copy link
Member

Closing since the only cnp.ndarray depends on a dtype.

@jjerphan jjerphan closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjerphan jjerphan jjerphan left review comments

Assignees
No one assigned
Labels
cython module:feature_extraction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npache @jjerphan
0