8000 MAINT Parameters validation for euclidean_distances by bkunde · Pull Request #25782 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Parameters validation for euclidean_distances #25782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2023
Merged

MAINT Parameters validation for euclidean_distances #25782

merged 4 commits into from
Jun 27, 2023

Conversation

bkunde
Copy link
Contributor
@bkunde bkunde commented Mar 8, 2023

Reference Issues/PRs

Towards #24862

**What does this implement/fix? Explain your changes.

Any other comments?**

@jeremiedbb jeremiedbb added No Changelog Needed Validation related to input validation labels Mar 9, 2023
@jeremiedbb
Copy link
Member

Thanks for the PR @bkunde. Although the PR looks good, I'd rather wait for the config option to disable param validation to be merged first (PR #25493). The reason is that euclidean_distances is used in some tight loops so the validation mechanism could cause a significant slow down.

@jeremiedbb
Copy link
Member

Also, there are linting issues. You can fix them by installing and running black=22.3.0, or by installing pre-commit

Veghit
Veghit 8000 approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor
@Veghit Veghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great.
+1 on what @jeremiedbb commented as for the linting issue in one file.

@jeremiedbb jeremiedbb mentioned this pull request Apr 7, 2023
Closed
@Shreesha3112 Shreesha3112 mentioned this pull request Jun 23, 2023
Closed
@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 9da8a1e. Link to the linter CI: here

jeremiedbb
jeremiedbb approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the conflicts and linting issue. LGTM. Thanks @bkunde

@jeremiedbb jeremiedbb enabled auto-merge (squash) June 27, 2023 13:46
@jeremiedbb jeremiedbb merged commit d3e11ab into scikit-learn:main Jun 27, 2023
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
@bkunde @jeremiedbb @punndcoder28
MAINT Parameters validation for euclidean_distances (scikit-learn#25782)
e7c02a2 
Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@bkunde @jeremiedbb @REDVM
MAINT Parameters validation for euclidean_distances (scikit-learn#25782)
ef8e8fd 
Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veghit Veghit Veghit approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:metrics No Changelog Needed Validation related to input validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkunde @jeremiedbb @Veghit
0