MAINT make plot_stock_market deterministic by fixing random state #25671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @tabeak, but since there's no randomness with the current |
|
I agree with @jeremiedbb. Here, we might be able to reduce the size of the image by tweaking matplotlib parameter but I am not sure about it. To convince ourself that there is no randomness, the graph created in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
related to #17568
What does this implement/fix? Explain your changes.
Added random state to the manifold.LocallyLinearEmbedding for fixing randomness.
It will avoid that the image is changing at each example generation.
Any other comments?
@adrinjalali @glemaitre