8000 CLN `cluster/_hdbscan/_tree.pyx` by Micky774 · Pull Request #25658 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CLN cluster/_hdbscan/_tree.pyx #25658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

CLN cluster/_hdbscan/_tree.pyx #25658

wants to merge 12 commits into from

Conversation

Micky774
Copy link
Contributor

Reference Issues/PRs

Towards #24686

What does this implement/fix? Explain your changes.

  1. Renames variables
  2. Changes typing to follow scikit-learn standard
  3. Introduces structured dtypes
  4. Simplifies algorithms
  5. Refactors code
  6. Utilizes new Cython syntax and standards

Any other comments?

@Micky774 Micky774 marked this pull request as draft February 22, 2023 01:25
@Micky774 Micky774 mentioned this pull request Feb 24, 2023
Closed
13 tasks
thomasjpfan
thomasjpfan reviewed Feb 24, 2023
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this many changes in one file, it's much easier to miss something.

Can this PR be split into multiple ones? At a glance, the following separate PRs:

  1. Stylistic changes such as np -> cnp and formatting changes can be it's own PR.
  2. TreeUnionFind refactor
  3. New Hierarchy data structure

I want to make sure the new hierarchy data structure is good, but the first two items are adds a bit more to look at.

@Micky774
Propogated use of common dtype
c8f190f
@Micky774
Renamed tree-->hierarchy
bb968e2
@Micky774
Added typing and updated documentation for dtype
< 8C5E input type="hidden" name="disable_live_updates" value="false" autocomplete="off" data-targets="batch-deferred-content.inputs" />
201b47c
@Micky774
Stylistic updates with removal of excess branches
24a227d
@Micky774 Micky774 mentioned this pull request Mar 6, 2023
Merged
@Micky774 Micky774 closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan left review comments

Assignees
No one assigned
Labels
cython module:cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Micky774 @thomasjpfan
0