Add _asarray_fn override to check_array
#25434
Conversation
There was a problem hiding this comment.
In a future where we would like estimators to be compatible with the array-API, we will need all np.asarray by our helper _asarray_with_order, I assume.
What is not clear to me is, how one would provide the array_fn in this case. Would it not be better to have somewhat a backend registered somewhere and pick up the asarray_fn provided, if one exists?
I am wondering if adding the keyword to check_array would become obsolete in the future.
I obviously missing some context because I did not review any of the plugin PRs.
| @@ -728,6 +729,17 @@ def check_array( | |||
|
|
|||
| .. versionadded:: 1.1.0 | |||
|
|
|||
| _asarray_fn : callable or None, default=None | |||
There was a problem hiding this comment.
This is a bit weird to add a "private" thing in a public function
| If not None, this callable will be used in place of calls to | ||
| `np.asarray` and `xp.asarray` (where `xp` can be any array namespace | ||
| implementing the Array API) when the data is converted to an array | ||
| object. Its signature must conform to the Array API specification for |
There was a problem hiding this comment.
| object. Its signature must conform to the Array API specification for | |
| object. Its signature must conform to the Array API specification for |
| implement a superset of the Array API specifications and need some of | ||
| the extra arguments for input conversion (such as `order`). | ||
|
|
||
| .. versionadded:: 1.3.0 |
There was a problem hiding this comment.
| .. versionadded:: 1.3.0 | |
| .. versionadded:: 1.3 |
| def _asarray_with_order(array, dtype=None, order=None, copy=None, xp=None): | ||
| """Helper to support the order kwarg only for NumPy-backed arrays | ||
| def _asarray_with_order( | ||
| array, dtype=None, order=None, copy=None, _asarray_fn=None, xp=None |
There was a problem hiding this comment.
Since we don't impose keywords only, it would be safer to place it at the last position even if this is a private function.
I'll try to add a bit of context. As a plugin you get passed the input the user provided when they call As part of its work I need to think about the idea of "plugin registers a |
Closes #25433