CI Remove unused env var #25359
Merged
CI Remove unused env var #25359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Jan 11, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jan 12, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The env var
TEST_DOCSTRINGSseems to have no impact. Despite defaulting tofalseand only set totruein 2 jobs, the docstrings are actually tested in almost all jobs (except windows and linux docker).What controls that is in fact
addopts = --doctest-modulesinsetup.cfg.I'm not sure how they are disable on windows and linux docker but it probably has to do with
sklearn/conftest.py?Anyway, this env var is not used anywhere in the project: these are all the 4 occurences. Just to be safe I also checked that it's not an env var that pytest would use.