8000 MNT minor clean-up of sklearn/conftests.py by lesteve · Pull Request #25358 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

MNT minor clean-up of sklearn/conftests.py #25358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Jan 11, 2023

Noticed an old comment about numpy >= 14, which is not relevant any more. Also there is a try/except which I don't think is needed.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Jan 11, 2023
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI is green.

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 26aaa86 into scikit-learn:main Jan 11, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jan 12, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023
@lesteve lesteve deleted the minor-sklearn-conftests-cleanup branch March 31, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0