ENH add feature_names_in_ in FeatureUnion #25220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added self._check_feature_names(...) to the .fit(...) method in FeatureUnion to allow access to the `.feature_names_in_` attribute if `X` has features names, e.g. a pandas.DataFrame - updated FeatureUnion docstring to reflect the addition of .feature_names_in_ attribute modified: sklearn/tests/test_pipeline.py - added test_feature_union_feature_names_in_() to test that FeatureUnion has a `.feature_names_in_` attribute if fitted with a pandas.DataFrame and not if fitted with a numpy array
- changelog updated with description of work
Kshitij68
reviewed
Dec 22, 2022
- made changelog description more precise
- typo -- removed period (.) before `columns`
- removed `self._check_feature_names(...) from `.fit(...)` method in `FeatureUnion` - added `feature_names_in_()` property to `FeatureUnion` to use first transformer's `feature_names_in_` attribute if present modified: sklearn/tests/test_pipeline.py - updated docstring for `test_feature_union_feature_names_in_()` to be more precise - added additional assertions to check if the `feature_names_in_` attribute is available to `FeatureUnion` if it's instantiated with a transformer that has already been fit
- updated changelog description to include `pandas.DataFrame` - corrected user signature to match github account
- added pandas import to `test_feature_union_feature_names_in_` so ImportError in azure-pipelines will pass
…it176131/scikit-learn into feature_union_feature_names_in_
thomasjpfan
reviewed
Jan 2, 2023
Member
There was a problem hiding this comment.
Thank you for the update!
newline/whitespace between change log updates. Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
added period at end of docstring Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
- removed train-test-split per code suggestion -- using `X` directly
Contributor
Author
|
@thomasjpfan -- I've made the changes you suggested. Ready for another review! 🙂 |
glemaitre
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
ENHANCEMENT #24754
What does this implement/fix? Explain your changes.
The
FeatureUnionclass did not previously have the.feature_names_in_attribute if fitted with apandas.DataFrame. This allows access to the attribute.Any other comments?
modified: sklearn/pipeline.py
self._check_feature_names(...)to the.fit(...)method inFeatureUnionto allow access to the.feature_names_in_attribute ifXhas features names, e.g. apandas.DataFrameFeatureUniondocstring to reflect the addition of.feature_names_in_attributemodified: sklearn/tests/test_pipeline.py
test_feature_union_feature_names_in_()to test thatFeatureUnionhas a.feature_names_in_attribute if fitted with apandas.DataFrameand not if fitted with anumpyarray