8000 MAINT Handle `Criterion.samples` using a memoryview by adam2392 · Pull Request #25005 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Handle Criterion.samples using a memoryview #25005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 1, 2022
Merged

MAINT Handle Criterion.samples using a memoryview #25005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
03e1d77
Initial commit
adam2392 Nov 23, 2022
4a2979b
Fix pip install
adam2392 Nov 23, 2022
1b4bd2e
Address comments about naming
adam2392 Nov 23, 2022
7722824
Fix indentation
adam2392 Nov 23, 2022
b47f79a
All fixed
adam2392 Nov 23, 2022
d059a30
Merge branch 'main' into samples
adam2392 Nov 23, 2022
7eab854
Merge branch 'main' into samples
adam2392 Nov 28, 2022
30a3f43
Merge branch 'main' into samples
adam2392 Nov 29, 2022
a9e7186
Merge branch 'main' into samples
adam2392 Nov 30, 2022
d223ff7
revert variable naming as suggested by @jjerphan
jshinm Dec 1, 2022
b29e109
Merge pull request #28 from jshinm/jms-update-samples
adam2392 Dec 1, 2022
5a13731
Update sklearn/tree/_criterion.pyx
adam2392 Dec 1, 2022
02d56c2
Add definitions
adam2392 Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sklearn/tree/_criterion.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ cdef class Criterion:
cdef const DOUBLE_t[:, ::1] y # Values of y
cdef const DOUBLE_t[:] sample_weight # Sample weights

cdef SIZE_t* samples # Sample indices in X, y
cdef const SIZE_t[:] sample_indices # Sample indices in X, y
cdef SIZE_t start # samples[start:pos] are the samples in the left node
cdef SIZE_t pos # samples[pos:end] are the samples in the right node
cdef SIZE_t end
Expand All @@ -46,7 +46,7 @@ cdef class Criterion:
const DOUBLE_t[:, ::1] y,
const DOUBLE_t[:] sample_weight,
double weighted_n_samples,
SIZE_t* samples,
const SIZE_t[:] sample_indices,
SIZE_t start,
SIZE_t end
) nogil except -1
Expand Down
Loading
0