8000 DOC Fix FutureWarning in plot_successive_halving_heatmap.html by ArturoAmorQ · Pull Request #24968 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Fix FutureWarning in plot_successive_halving_heatmap.html #24968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2022
Merged

DOC Fix FutureWarning in plot_successive_halving_heatmap.html #24968

merged 3 commits into from
Nov 17, 2022
+4 −2

Conversation

ArturoAmorQ
Copy link
Member

Reference Issues/PRs

Fix towards #24876.

What does this implement/fix? Explain your changes.

Fixed FutureWarning:
In a future version, the Index constructor will not infer numeric dtypes when passed object-dtype sequences (matching Series behavior)

Any other comments?

I was investigating to be able to answer this comment by @Reddragonemperor58, then decided it was easier to just submit the PR.

@ArturoAmorQ ArturoAmorQ mentioned this pull request Nov 17, 2022
Closed
25 tasks
@Reddragonemperor58
Copy link
Contributor

Nicely done👍

glemaitre
glemaitre reviewed Nov 17, 2022
View reviewed changes
ArturoAmorQ and others added 2 commits November 17, 2022 14:09
@ArturoAmorQ @glemaitre
Apply suggestions from code review
b6706e5 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Remove unused line of code
6c87efa
jeremiedbb
jeremiedbb approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ArturoAmorQ

@jeremiedbb jeremiedbb merged commit 43550f0 into scikit-learn:main Nov 17, 2022
@ArturoAmorQ ArturoAmorQ deleted the fix_future_warning branch February 17, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArturoAmorQ @Reddragonemperor58 @glemaitre @jeremiedbb
0