8000 DOC Fix FutureWarning in model_selection/plot_grid_search_text_feature_extraction.html by isaac-chung · Pull Request #24961 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content
8000

DOC Fix FutureWarning in model_selection/plot_grid_search_text_feature_extraction.html #24961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

isaac-chung
Copy link

Reference Issues/PRs

Fix towards #24876 .

What does this implement/fix? Explain your changes.

Fixed the FutureWarning in model_selection/plot_grid_search_text_feature_extraction.html by explicitly setting force_alpha=True for ComplementNB.

Warning from: sklearn\naive_bayes.pyL#627

Any other comments?

@isaac-chung isaac-chung changed the title DOC Fix FutureWarning in plot_grid_search_text_feature_extraction example DOC Fix FutureWarning in model_selection/plot_grid_search_text_feature_extraction.html Nov 16, 2022
@isaac-chung isaac-chung changed the title DOC Fix FutureWarning in model_selection/plot_grid_search_text_feature_extraction.html [MRG] DOC Fix FutureWarning in model_selection/plot_grid_search_text_feature_extraction.html Nov 17, 2022
@glemaitre glemaitre changed the title [MRG] DOC Fix FutureWarning in model_selection/plot_grid_search_text_feature_extraction.html DOC Fix FutureWarning in model_selection/plot_grid_search_text_feature_extraction.html Nov 17, 2022
@glemaitre
Copy link
Member

There is no such warning in this example. alpha is always greater than 1e-10 and the warning for the change in the future is not triggered.

However, there is a warning triggered in plotly:

/home/runner/mambaforge/envs/testenv/lib/python3.9/site-packages/plotly/express/_core.py:279: FutureWarning:

iteritems is deprecated and will be removed in a future version. Use .items instead.

We don't need to fix it because plotly need to fix it. There is a PR for that: plotly/plotly.py#3923

Then closing this PR. Thanks @isaac-chung to have a look at this example. I will mark it as done in the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0