8000 DOC Fix FutureWarning in manifold/plot_lle_digits.html by MaximSmolskiy · Pull Request #24922 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Fix FutureWarning in manifold/plot_lle_digits.html #24922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 15, 2022
Merged

DOC Fix FutureWarning in manifold/plot_lle_digits.html #24922

merged 6 commits into from
Nov 15, 2022

Conversation

MaximSmolskiy
Copy link
Contributor

Reference Issues/PRs

Related to #24876

What does this implement/fix? Explain your changes.

Fix FutureWarning in manifold/plot_lle_digits.html

/home/runner/work/scikit-learn/scikit-learn/sklearn/manifold/_mds.py:299: FutureWarning:

The default value of `normalized_stress` will change to `'auto'` in version 1.4. To suppress this warning, manually set the value of `normalized_stress`.

by explicit passing normalized_stress=False

Any other comments?

betatim
betatim reviewed Nov 15, 2022
View reviewed changes
@ArturoAmorQ ArturoAmorQ mentioned this pull request Nov 15, 2022
Closed
25 tasks
glemaitre
glemaitre approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comment of @betatim is accepted, LGTM.

@glemaitre glemaitre self-requested a review November 15, 2022 16:03
glemaitre
glemaitre approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merge main into the branch because I introduced a black error in main and solve it. The linting CI should not error anymore.

@glemaitre glemaitre merged commit edb2c86 into scikit-learn:main Nov 15, 2022
@MaximSmolskiy MaximSmolskiy deleted the doc-fix-FutureWarning-in-manifold/plot_lle_digits.html branch November 15, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim left review comments

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximSmolskiy @betatim @glemaitre
0