DOC Rework IsolationForest example #24917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Nov 14, 2022
| loc="upper left", | ||
| ) | ||
| disp.ax_.set_title("Path length decision boundary of IsolationForest") |
There was a problem hiding this comment.
It could be nice to have a colorbar or have the level of the isoline in terms of the decision. I don't recall if setting plot_method="pcolormesh" would make the level of the isoline. But we can for sure add a colorbar otherwise (cf. quick example)
There was a problem hiding this comment.
It's done, but I am having problems with interpreting the colorbar, so any feedback on that side is really appreciated!
There was a problem hiding this comment.
It corresponds to the score of confidence to be an outlier or not. 1 is an inlier and 0 is an outlier.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16113.
What does this implement/fix? Explain your changes.
The original narrative labels samples as "training observations", "new regular observations" and "new abnormal observations". This PR labels samples as "outlier" vs "inlier", which is closer to a real life user case.
This PR also implements a discrete decision boundary and a bit of narration, has suggested in this comment. For such purpose it uses a
DecisionBoundaryDisplay, as it reduces boilerplate code and helps keeping the attention on the interpretation.Any other comments?
Side effect: Implements notebook style as intended in #22406.
Part of the "tutorialization" series.