8000 DOC Fix FutureWarning in 'applications/plot_cyclical_feature_engineering.html' by Ti-Ion · Pull Request #24892 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Fix FutureWarning in 'applications/plot_cyclical_feature_engineering.html' #24892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2022
Merged

DOC Fix FutureWarning in 'applications/plot_cyclical_feature_engineering.html' #24892

merged 3 commits into from
Nov 12, 2022

Conversation

Ti-Ion
Copy link
Contributor
@Ti-Ion Ti-Ion commented Nov 11, 2022

Reference Issues/PRs

towards #24876

What does this implement/fix? Explain your changes.

Fixed the FutureWarning in plot_cyclical_feature_engineering example

Any other comments?

Not 100% sure numeric_only=True is correct but it seems to work.

@betatim
Copy link
Member
betatim commented Nov 11, 2022

I think your numeric_only fix is the right thing to do. The default value in pandas is about to change, and because the example wasn't explicitly choosing a value the warning was raised.

thomasjpfan
thomasjpfan reviewed Nov 11, 2022
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! @Ti-Ion !

thomasjpfan
thomasjpfan approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit c98b910 into scikit-learn:main Nov 12, 2022
@ArturoAmorQ ArturoAmorQ mentioned this pull request Nov 13, 2022
Closed
25 tasks
@Ti-Ion Ti-Ion deleted the cyclical_feature_engi_futurewarning_fix branch November 13, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ti-Ion @betatim @thomasjpfan
0