8000 DOC Improve narrative of DBSCAN example by ArturoAmorQ · Pull Request #24874 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Improve narrative of DBSCAN example #24874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 10, 2022
Merged

DOC Improve narrative of DBSCAN example #24874

merged 5 commits into from
Nov 10, 2022

Conversation

ArturoAmorQ
Copy link
Member

Reference Issues/PRs

Somewhat related to #22406.

What does this implement/fix? Explain your changes.

This PR implements cosmetic changes to the DBSCAN example with the intention of making the contents more didactic.

Any other comments?

Notebook style was already implemented, but the narrative can benefit from a "tutorialization".

betatim
betatim reviewed Nov 9, 2022
View reviewed changes
ArturoAmorQ and others added 2 commits November 9, 2022 15:43
@ArturoAmorQ @betatim
Apply suggestions from code review
63578b7 
Co-authored-by: Tim Head <betatim@gmail.com>
Improve wording
85c4e9d
betatim
betatim approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member
@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement over main -> LGTM

@adrinjalali adrinjalali merged commit 539cd6c into scikit-learn:main Nov 10, 2022
@ArturoAmorQ ArturoAmorQ deleted the revamp_dbscan branch November 10, 2022 09:14
@ArturoAmorQ ArturoAmorQ mentioned this pull request Nov 16, 2022
Merged
@ArturoAmorQ ArturoAmorQ changed the title DOC Improve narrative of DBSCAN example narrative DOC Improve narrative of DBSCAN example Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArturoAmorQ @betatim @adrinjalali
0