ENH Add gamma='scale' option to RBFSampler #24755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
approved these changes
Oct 26, 2022
jeremiedbb
approved these changes
Oct 28, 2022
jjerphan
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Oct 28, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
andportnoy
pushed a commit
to andportnoy/scikit-learn
that referenced
this pull request
Nov 5, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24748
What does this implement/fix? Explain your changes.
Added gamma='scale' option to RBFSampler;
Added small test for scale calculation, just like in svm test file (maybe excessive?);
Changed userdocs and parameter constraints accordingly.
Any other comments?
Also took the liberty to replace numpy calls on numbers to python functions, which should be faster. If it was unnecessary, I'll revert it.