8000 MAINT set joblib min to 1.1.1 by ogrisel · Pull Request #24621 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT set joblib min to 1.1.1 #24621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2022
Merged

MAINT set joblib min to 1.1.1 #24621

merged 2 commits into from
Oct 10, 2022

Conversation

ogrisel
Copy link
Member
@ogrisel ogrisel commented Oct 10, 2022

As discussed in #24401.

I also ran python build_tools/update_environments_and_lock_files.py to updated other "latest" dependencies on the CI.

@ogrisel
Copy link
Member Author
ogrisel commented Oct 10, 2022
  • Windows py38_pip_openblas_32bit is failing because there is not 32 bit windows wheel for the recent scipy 1.9.2 release, there is only: scipy-1.9.2-cp38-cp38-win_amd64.whl

The 2 linux failures in test_min_dependencies_readme because I forgot to update the README. Will do it now.

@ogrisel ogrisel mentioned this pull request Oct 10, 2022
Closed
thomasjpfan
thomasjpfan reviewed Oct 10, 2022
View reviewed changes
build_tools/update_environments_and_lock_files.py
@@ -349,6 +349,9 @@ def remove_from(alist, to_remove):
# pip-compile, we are going to assume the pip lock file on a Linux
# 64bit machine gives appropriate versions
"python_version": "3.8.10",
"package_constraints": {
"scipy": "1.9.1", # 1.9.2 not available for 32 bit Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

I think pip needs to be configured with the --prefer-binary option to prefer the wheel over building the source. Coming from jazzband/pip-tools#1119, pip-tools can be configured to prefer binary with the PIP_PREFER_BINARY environment variable.

Given that this is only used to generate the lock files, I slightly prefer the pinning solution that is already in this PR.

Copy link
Member Author
@ogrisel ogrisel Oct 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

The --prefer-binary option is probably a good idea to fix the wheel building problem discussed in #24612 (comment).

@ogrisel
Copy link
Member Author
ogrisel commented Oct 10, 2022

CI is green/blue! Merge?

thomasjpfan
thomasjpfan approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 50b818e into scikit-learn:main Oct 10, 2022
@cmarmo cmarmo mentioned this pull request Oct 10, 2022
Merged
@ogrisel ogrisel deleted the bump-up-ci-deps-joblib-min-1.1.1 branch October 10, 2022 21:18
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
@ogrisel @glemaitre
MAINT set joblib min to 1.1.1 (scikit-learn#24621)
2fc9bbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Build / CI Packaging
Projects
Non 4447 e yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogrisel @thomasjpfan
0