8000 TST use global_random_seed in sklearn/cluster/tests/test_dbscan.py by OmarManzoor · Pull Request #24598 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST use global_random_seed in sklearn/cluster/tests/test_dbscan.py #24598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2022
Merged

TST use global_random_seed in sklearn/cluster/tests/test_dbscan.py #24598

merged 2 commits into from
Oct 17, 2022

Conversation

OmarManzoor
Copy link
Contributor

Reference Issues/PRs

Towards: #22827

What does this implement/fix? Explain your changes.

  • Added the global_random_seed fixture in test_dbscan.py
  • The only addition is in test_weighted_dbscan.

Any other comments?

ogrisel
ogrisel approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked locally that:

SKLEARN_TESTS_GLOBAL_RANDOM_SEED="all" pytest -v -k test_weighted_dbscan sklearn/cluster/tests/test_dbscan.py

works.

Thanks for the fix!

@ogrisel ogrisel merged commit 625650f into scikit-learn:main Oct 17, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
@OmarManzoor @glemaitre
TST use global_random_seed in sklearn/cluster/tests/test_dbscan.py (s…
b736d2e 
…cikit-learn#24598)
@OmarManzoor OmarManzoor deleted the test_dbscan_global_random_seed branch April 3, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
module:cluster No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmarManzoor @ogrisel @adrinjalali
0