8000 DOC make `plot_mean_shift.py` more colourblind friendly by rprkh · Pull Request #24553 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC make plot_mean_shift.py more colourblind friendly #24553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

rprkh
Copy link
Contributor
@rprkh rprkh commented Sep 30, 2022

Reference Issues/PRs

Towards #5435
Related to #5435 (comment)

What does this implement/fix? Explain your changes.

Includes markers and a more colourblind friendly palette

Any other comments?

Details

Original Image (Deuteranopia)
image

Revised Image (Deutranopia)
image

Original Image (Protanopia)
image

Revised Image (Protanopia)
image

Original Image (Tritanopia)
image

Revised Image (Tritanopia)
image

@adrinjalali
Copy link
Member

@rprkh thanks for the PR. Please update your branch with the latest main (https://scikit-learn.org/stable/developers/contributing.html#how-to-contribute)

@rprkh
Copy link
Contributor Author
rprkh commented Oct 1, 2022

Resolved merge conflicts and updated the branch with main

Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rprkh

@adrinjalali adrinjalali merged commit 14684bb into scikit-learn:main Oct 4, 2022
@rprkh rprkh deleted the cb_friendly_mean_shift branch October 4, 2022 08:28
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Oct 9, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0