8000 ENH Add dtype preservation to SkewedChi2Sampler by rprkh · Pull Request #24349 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Add dtype preservation to SkewedChi2Sampler #24349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ENH Add dtype preservation to SkewedChi2Sampler #24349

wants to merge 2 commits into from

Conversation

rprkh
Copy link
Contributor
@rprkh rprkh commented Sep 4, 2022 •
edited
Loading

Reference Issues/PRs

Towards #11000

What does this implement/fix? Explain your changes.

SkewedChi2Sampler uses float32 when the input X is float32, otherwise it uses float64 as before.

Any other comments?

Creating another PR for this due to merge conflicts that cannot be resolved.

From https://github.com/rprkh/scikit-learn
 * branch                preserve_dtype_skewedchi2sampler -> FETCH_HEAD
Auto-merging sklearn/kernel_approximation.py
CONFLICT (content): Merge conflict in sklearn/kernel_approximation.py
Auto-merging doc/whats_new/v1.2.rst
CONFLICT (content): Merge conflict in doc/whats_new/v1.2.rst
Automatic merge failed; fix conflicts and then commit the result.

@rprkh rprkh closed this Sep 4, 2022
@rprkh rprkh deleted the preserve_dtype_skewedchi2sampler branch September 4, 2022 09:07
@rprkh rprkh mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rprkh
0