8000 MAINT Add parameter validation to `PolynomialFeatures` by stefmolin · Pull Request #24214 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Add parameter validation to PolynomialFeatures #24214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2022
Merged

MAINT Add parameter validation to PolynomialFeatures #24214

merged 3 commits into from
Aug 29, 2022

Conversation

stefmolin
Copy link
Contributor

Reference Issues/PRs

Towards #23462

What does this implement/fix? Explain your changes.

  • Add parameter validation to PolynomialFeatures.
  • Fixed a typo in an error message and the corresponding test.

Any other comments?

There will be a conflict with #24057. Feel free to merge that one first since it was created earlier.

@glemaitre glemaitre changed the title MAINT Add parameter validation to PolynomialFeatures. MAINT Add parameter validation to PolynomialFeatures Aug 22, 2022
@glemaitre glemaitre self-requested a review August 22, 2022 14:15
glemaitre
glemaitre approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.
Thanks @stefmolin

@glemaitre glemaitre self-requested a review August 23, 2022 14:59
@glemaitre glemaitre added the Validation related to input validation label Aug 23, 2022
thomasjpfan
thomasjpfan approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan merged commit ca4e076 into scikit-learn:main Aug 29, 2022
@stefmolin stefmolin deleted the maint/polynomial-features branch August 29, 2022 15:08
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
@stefmolin @glemaitre
MAINT Add parameter validation to PolynomialFeatures (scikit-learn#…
9442dab 
…24214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:preprocessing No Changelog Needed Validation related to input validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefmolin @thomasjpfan @glemaitre
0