10000 TST Fix `test_pairwise_distances_argkmin` xfail by jjerphan · Pull Request #24168 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

TST Fix test_pairwise_distances_argkmin xfail #24168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jjerphan
Copy link
Member

Reference Issues/PRs

Relates to #24131

What does this implement/fix? Explain your changes.

This fixes test_pairwise_distances_argkmin xfail.

Resolves one problem observed on #24131 (comment).

Any other comments?

Thanks for the heads-up, @lesteve

@lesteve
Copy link
Member
lesteve commented Aug 11, 2022

LGTM, this fixes the issue for me locally, merging. Thanks a lot!

@lesteve lesteve merged commit c900ad3 into scikit-learn:main Aug 11, 2022
@jjerphan jjerphan deleted the tst/fix-test_pairwise_distances_argkmin-xfail branch August 11, 2022 12:16
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0