10000 MNT fix linter issues related to multioutput by adrinjalali · Pull Request #24143 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

MNT fix linter issues related to multioutput #24143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

adrinjalali
Copy link
Member
@adrinjalali adrinjalali commented Aug 8, 2022

Fixes linter issues related to multioutput which were not detected by the CI, or were mistakes by my merge from main.

cc @thomasjpfan @BenjaminBossan

@BenjaminBossan
Copy link
Contributor

I didn't review line by line but since the linter is green now, this should be good to merge.

@adrinjalali
Copy link
Member Author

I just ran isort on the files, no manual change.

@BenjaminBossan
Copy link
Contributor

I just ran isort on the files, no manual change.

isort of expected that

(okay, I'll see myself out)

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running isort makes it harder to see what this actually changed. I was able to figure it out only by looking at the linting error in the other PR

There is also strange ordering with the "Authors" section and the abc import. I prefer fixing the linting issues directly without isort.

Comment on lines 9 to 10
from abc import ABCMeta, abstractmethod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being imported before the # Authors section. I'm guessing isort needs an empty line above from numbers import Integral to function correctly.

@adrinjalali
Copy link
Member Author

Merge this one?

@thomasjpfan thomasjpfan merged commit 6b678c0 into scikit-learn:sample-props Aug 10, 2022
@adrinjalali adrinjalali deleted the slep6/lint-fix branch August 10, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0