8000 DOC Update MDS init docs in fit by thomasjpfan · Pull Request #24070 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Update MDS init docs in fit #24070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2022
Merged

DOC Update MDS init docs in fit #24070

merged 1 commit into from
Aug 5, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Follow up to #24067
Issue #22265

What does this implement/fix? Explain your changes.

Adds n_components to init docstring. This update is consistent with the smacof docstring that MDS uses:

scikit-learn/sklearn/manifold/_mds.py

Lines 222 to 224 in ec6efc5

init : ndarray of shape (n_samples, n_components), default=None
Starting configuration of the embedding to initialize the algorithm. By
default, the algorithm is initialized with a randomly chosen array.

@jjerphan jjerphan merged commit 0a93e16 into scikit-learn:main Aug 5, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
@thomasjpfan @glemaitre
DOC Update MDS init docs in fit (scikit-learn#24070)
ed05c40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
Documentation module:manifold No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasjpfan @jjerphan
0