8000 FIX Show a HTML repr for meta-estimatosr with invalid parameters by thomasjpfan · Pull Request #24015 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX Show a HTML repr for meta-estimatosr with invalid parameters #24015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glemaitre merged 4 commits into from
Jul 27, 2022
Merged

FIX Show a HTML repr for meta-estimatosr with invalid parameters #24015

glemaitre merged 4 commits into from
Jul 27, 2022

Conversation

@thomasjpfan
Copy link
Member
@thomasjpfan thomasjpfan commented Jul 26, 2022

Reference Issues/PRs

Fixes #24009

What does this implement/fix? Explain your changes.

For the case of _sk_visual_block_, this PR enhances _get_visual_block to have a better default if _sk_visual_block_ fails for any reason. The default here is to treat the meta-estimator as a single estimator:

Screen Shot 2022-07-26 at 1 05 41 PM

Any other comments?

The alternative is to adjust all the meta-estimators and validate some parameters in _sk_visual_block_.

@thomasjpfan thomasjpfan added this to the 1.1.2 milestone Jul 26, 2022
@thomasjpfan thomasjpfan mentioned this pull request Jul 26, 2022
Closed
jeremiedbb
jeremiedbb approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this approach rather than validating params in _sk_visual_block_

thomasjpfan and others added 2 commits July 26, 2022 14:59
@thomasjpfan @jeremiedbb
Update doc/whats_new/v1.1.rst
cac6090 
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@thomasjpfan
DOC Grammar
f295e20
@glemaitre glemaitre merged commit 84c6421 into scikit-learn:main Jul 27, 2022
@glemaitre
Copy link
Member
glemaitre commented Jul 27, 2022

Thanks @thomasjpfan LGTM. Merging

@hsorsky hsorsky mentioned this pull request Jul 28, 2022
Merged
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
@thomasjpfan @jeremiedbb @glemaitre
FIX Show a HTML repr for meta-estimatosr with invalid parameters (sci…
00b2e2d 
…kit-learn#24015)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
@thomasjpfan @jeremiedbb @glemaitre
FIX Show a HTML repr for meta-estimatosr with invalid parameters (#24015
7675a6f 
)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees

No one assigned

Labels

module:utils

Projects

None yet

Milestone

1.1.2

Development

Successfully merging this pull request may close these issues.

_sk_visual_block can be executed before parameter validation

3 participants

@thomasjpfan @glemaitre @jeremiedbb
0