8000 CI Error on numpy.VisibleDeprecationWarning in CI by thomasjpfan · Pull Request #23971 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Error on numpy.VisibleDeprecationWarning in CI #23971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2022
Merged

CI Error on numpy.VisibleDeprecationWarning in CI #23971

merged 5 commits into from
Jul 25, 2022

Conversation

thomasjpfan
Copy link
Member
@thomasjpfan thomasjpfan commented Jul 21, 2022 •
edited by jeremiedbb
Loading

Reference Issues/PRs

ref #5685

What does this implement/fix? Explain your changes.

This PR switches all numpy.VisibleDeprecationWarnings to error when warnings are checked on the CI.

@thomasjpfan thomasjpfan added No Changelog Needed Quick Review For PRs that are quick to review labels Jul 22, 2022
jjerphan
jjerphan approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @thomasjpfan.

@thomasjpfan @jjerphan
Apply suggestions from code review
22609b1 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@thomasjpfan @jjerphan
Apply suggestions from code review
3545f48 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jeremiedbb
jeremiedbb approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks

@jeremiedbb
Copy link
Member
jeremiedbb commented Jul 25, 2022 •
edited
Loading

@thomasjpfan I updated the description because it doesn't it really address the original goal of #5685 (which was to raise on all warnings). However I'm ok to close the issue since we don't plan to raise on all warnings anyway.

@jeremiedbb jeremiedbb merged commit a3dcf33 into scikit-learn:main Jul 25, 2022
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
@glemaitre @jjerphan
CI Error on numpy.VisibleDeprecationWarning in CI (scikit-learn#23971)
6e05c8e 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
glemaitre added a commit that referenced this pull request Aug 5, 2022
@glemaitre @jjerphan
CI Error on numpy.VisibleDeprecationWarning in CI (#23971)
d8ab556 
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjerphan jjerphan jjerphan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Build / CI No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @jeremiedbb @jjerphan
0