DOC Give local recommendations about SimpleImputer in docstring #23714
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
glemaitre
reviewed
Jun 23, 2022
Member
There was a problem hiding this comment.
It might be worth adding here (and to other estimators) that adding the mask corresponding to the original missing values could be useful in practice if the missingness is informative.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
aperezlebel
added a commit
to aperezlebel/scikit-learn
that referenced
this pull request
Jun 23, 2022
Member
|
LGTM. I discarded the two suggestions pending. Thanks @aperezlebel |
A78F
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…it-learn#23714) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses task 3 of #21967
What does this implement/fix? Explain your changes.
Adapt the docstring of
SimpleImputerto give local recommendations.