8000 DOC Give local recommendations about SimpleImputer in docstring by aperezlebel · Pull Request #23714 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Give local recommendations about SimpleImputer in docstring #23714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 27, 2022
Merged

DOC Give local recommendations about SimpleImputer in docstring #23714

merged 7 commits into from
Jul 27, 2022

Conversation

aperezlebel
Copy link
Contributor

Reference Issues/PRs

Addresses task 3 of #21967

What does this implement/fix? Explain your changes.

Adapt the docstring of SimpleImputer to give local recommendations.

@aperezlebel aperezlebel mentioned this pull request Jun 21, 2022
Open
7 tasks
glemaitre
glemaitre reviewed Jun 23, 2022
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding here (and to other estimators) that adding the mask corresponding to the original missing values could be useful in practice if the missingness is informative.

aperezlebel and others added 3 commits June 23, 2022 18:13
@aperezlebel @glemaitre
Update sklearn/impute/_base.py
b244fca 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@aperezlebel @glemaitre
Update sklearn/impute/_base.py
a841045 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@aperezlebel @glemaitre
Update sklearn/impute/_base.py
c437464 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
aperezlebel added a commit to aperezlebel/scikit-learn that referenced this pull request Jun 23, 2022
@aperezlebel
Update "see also" part to be consistent with scikit-learn#23714
001ff6c
@glemaitre glemaitre merged commit 9824d15 into scikit-learn:main Jul 27, 2022
@glemaitre
Copy link
Member

LGTM. I discarded the two suggestions pending. Thanks @aperezlebel

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
@aperezlebel @glemaitre
DOC Give local recommendations about SimpleImputer in docstring (scik…
08f7e10 
…it-learn#23714)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Aug 5, 2022
@aperezlebel @glemaitre
DOC Give local recommendations about SimpleImputer in docstring (#23714)
8e941b5 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre 5138 glemaitre left review comments

Assignees
No one assigned
Labels
Documentation module:impute
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aperezlebel @glemaitre
0