8000 MNT fix body too long in update_tracking_issue.py by lesteve · Pull Request #23615 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT fix body too long in update_tracking_issue.py #23615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2022
Merged

MNT fix body too long in update_tracking_issue.py #23615

merged 1 commit into from
Jun 14, 2022

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Jun 14, 2022

Plenty of tests failed in scipy_dev #23614.

The script creating the issue automatically fails because the body is too long:
https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=43215&view=logs&j=dfe99b15-50db-5d7b-b1e9-4105c42527cf&t=a806c63c-6a55-5993-5e78-a1ba6c47dc00

This is a simple fix so that at least we get an issue about this

@lesteve lesteve mentioned this pull request Jun 14, 2022
Closed
glemaitre
glemaitre approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jjerphan
jjerphan approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @lesteve.

@jjerphan jjerphan merged commit dbe3945 into scikit-learn:main Jun 14, 2022
@lesteve lesteve deleted the fix-body-too-long branch June 14, 2022 15:22
@lesteve
Copy link
Member Author
lesteve commented Jun 14, 2022

I guess we'll see for the next nightly build if the script does create the issue with truncated body 😉

@lesteve
Copy link
Member Author
lesteve commented Jun 15, 2022

This worked #23626

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
@lesteve @ogrisel
MNT fix body too long in update_tracking_issue.py (scikit-learn#23615)
78661d7
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
@lesteve @glemaitre
MNT fix body too long in update_tracking_issue.py (scikit-learn#23615)
240c4a9
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
@lesteve @glemaitre
MNT fix body too long in update_tracking_issue.py (#23615)
8ec1ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@jjerphan jjerphan jjerphan approved these changes

@Rhuziella Rhuziella Rhuziella approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lesteve @glemaitre @jjerphan @Rhuziella
0