[MRG] Fix sklearn.utils._param_validation._InstancesOf is insufficient for numpy data types #23600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Jun 12, 2022
| def __init__(self, type): | ||
| self.type = type | ||
| def __init__(self, param_type): | ||
| self.param_type = param_type |
There was a problem hiding this comment.
As commented in #23599 (comment):
The "type" here is not the builtin type anymore but the locally scoped "type". A simple Python example:
class A:
def __init__(self, type):
self.type = type
a = A(100)
print(a.type)
# 100There was a problem hiding this comment.
Thank you for clarifiying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #23599
What does this implement/fix? Explain your changes.
sklearn.utils._param_validation._InstancesOf currently doesn't support numpy data types. The fix changes
self.typeintoself.param_typeto allow testing for different types than the built-in 'type'.Any other comments?
This fix is necessary to implement validate_params (#23462) in objects that have numpy data types as parameters (e.g. #23579).