CI reduce verbosity of build_doc.sh #23557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to properly configure a per-branch or per-PR cache folder to be reused for ccache to work as expected for the doc builds but I would rather not do it as part of this PR. I think this is already a net improvement: the logs of the last is much easier to parse than previously. See for instance this log: https://github.com/scikit-learn/scikit-learn/runs/6771165338?check_suite_focus=true |
thomasjpfan
approved these changes
Jun 7, 2022
ogrisel
added a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log of the documentation build is very verbose and can sometimes lead firefox to display black pages with a very long scroll bars for several seconds making it painful to read the error message when working on a failing example (e.g. https://github.com/scikit-learn/scikit-learn/runs/6754051284?check_suite_focus=true).
This PRs changes a few things in the build_doc.sh script to make that log shorter and focused on documentation related issues:
try to useremove all verbose bash optionsset -vinstead ofset -xpipto hide the build log by default when there is not build problem.I also renamed variables related to miniconda to account 8000 for the switch to mambaforge.