8000 DOC: contributors logos added to index screen footer by jaquesgrobler · Pull Request #2350 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC: contributors logos added to index screen footer #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jaquesgrobler
Copy link
Member

for #2333

They also show tooltips upon mouse-over (currently just the sponsors name, for in case the logo isn't clear)

Fullscreen:

screenshot at 2013-08-07 17 26 15

Zoomed

screenshot at 2013-08-07 17 26 23

Feedback welcome

@jaquesgrobler
Copy link
Member Author

Latest

screenshot at 2013-08-07 17 41 47

@jaquesgrobler
Copy link
Member Author

Fixed those silly underscores that snuck in between the images.

Now it's like this again

screenshot at 2013-08-07 17 52 51

@mblondel
Copy link
Member
mblondel commented Aug 7, 2013

I think we could add an "About us" link in the upper orange menu.

@GaelVaroquaux
Copy link
Member

I think we could add an "About us" link in the upper orange menu.

I'd rather not: the whole goal of this rewrite was to limit the amount of
information that is "prioritized", as their was an information overload.

@mblondel
Copy link
Member
mblondel commented Aug 7, 2013

I think this is very important information. We need a way to reach the author list page from the homepage and not just a tiny link in the lower right corner.

@jaquesgrobler
Copy link
Member Author

@GaelVaroquaux @mblondel

I think this is very important information. We need a way to reach the author list page from the homepage and not just a tiny link in the lower right corner.

What about something like this ?
Scroll up and down and check on the left

(obviously with different colours and writing).. it's pretty simple to implement, but not everyone likes it

it's javascript free too 😬

@GaelVaroquaux
Copy link
Member

How about simply adding a line with a link in the 'Community' tab, above
'Questions'. This would be more visible than the current link that is
quite hidden and would be where I would be looking for it.

@jaquesgrobler
Copy link
Member Author

How about simply adding a line with a link in the 'Community' tab, above
'Questions'. This would be more visible than the current link that is
quite hidden and would be where I would be looking for it.

I can do that (unless you like my above idea more haha)

@GaelVaroquaux
Copy link
Member

I can do that (unless you like my above idea more haha)

I think that I prefer my option. The new website has recieved a lot of
work to make it look less crowded, we need to be careful not to add
visual noise back to it.

@mblondel
Copy link
Member
mblondel commented Aug 8, 2013

How about simply adding a line with a link in the 'Community' tab, above 'Questions'. This would be more visible than the current link that is quite hidden and would be where I would be looking for it.

That would be fine with me. In addition, in the "copyright 2010-2013 scikit-learn developers" I would add a link to the author list on the word "developers".

@GaelVaroquaux
Copy link
Member

That would be fine with me. In addition, in the "copyright 2010-2013
scikit-learn developers" I would add a link to the author list on the word
"developers".

OK, this is a great suggestion!

@GaelVaroquaux
Copy link
Member

@jaquesgrobler : when you have a moment (I know that you are busy with the nilearn website), could you do the last item and merge this: I am writing a grant to get money to fund scikit-learn development, and it would help me a lot.

jaquesgrobler added a commit that referenced this pull request Sep 17, 2013
DOC: contributors logos added to index screen footer
@jaquesgrobler jaquesgrobler merged commit 8765d95 into scikit-learn:master Sep 17, 2013
@jaquesgrobler
Copy link
Member Author

@GaelVaroquaux merged it - sorry for the delay - didn't see your message while I was on nilearn site work :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0