DOC Rework plot_hashing_vs_dict_vectorizer.py example #23266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2022 15:06
ogrisel
reviewed
May 19, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
added 4 commits
May 20, 2022 12:16
ogrisel
approved these changes
May 23, 2022
There was a problem hiding this comment.
Thanks very much @ArturoAmorQ, this notebook is much nicer than the original benchmark script.
Here is a final batch of suggestions for improvement:
ogrisel
reviewed
May 25, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…nto compare_vectorizers
…earn into compare_vectorizers
jjerphan
reviewed
May 30, 2022
There was a problem hiding this comment.
Thank you, @ArturoAmorQ.
I think one should use other terms to make this example more accurate.
This is for instance the case of:
- "frequency" which can be replace by "occurence (counts)" (to respect the the definition)
- "speed" which can be replaced by "data processing rate" (to respect the unit (bytes/sec))
Here are some comments and formatting fixes.
Edit: not related to this PR, but #23004 might come with new changes for this example then.
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
approved these changes
May 30, 2022
There was a problem hiding this comment.
Thank you, @ArturoAmorQ.
Edit: I let @ogrisel merge if everything LGTH.
ArturoAmorQ
commented
May 30, 2022
ogrisel
approved these changes
May 30, 2022
ogrisel
reviewed
May 30, 2022
ogrisel
reviewed
May 30, 2022
|
Merged, thank you very much for the nice contribution @ArturoAmorQ! |
ogrisel
added a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
…3266) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…3266) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #22928
What does this implement/fix? Explain your changes.
In #22928 we remove the use of
HashingVectorizerfrom the plot_document_classification_20newsgroups.py example for the sake of simplicity.A comparison of the performance of hashers and vectorizers can be moved to this existing example.
Any other comments?
Side effect: Implements notebook style as intended in #22406