8000 TST Speed-up test_minibatch_dictionary_learning_dtype_match by jeremiedbb · Pull Request #23186 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

TST Speed-up test_minibatch_dictionary_learning_dtype_match #23186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jeremiedbb
Copy link
Member

This test takes almost 1min to run locally. I can't imagine on azure. This PR makes it run in less than 2 secs.

@jeremiedbb jeremiedbb added module:decomposition module:test-suite everything related to our tests Quick Review For PRs that are quick to review No Changelog Needed labels Apr 22, 2022
@@ -911,9 +911,12 @@ def test_minibatch_dictionary_learning_dtype_match(
batch_size=10,
fit_algorithm=fit_algorithm,
transform_algorithm=transform_algorithm,
max_iter=100,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set max_iter to get the new behavior (old behavior doesn't have stopping criterion besides n_iter).

@@ -911,9 +911,12 @@ def test_minibatch_dictionary_learning_dtype_match(
batch_size=10,
fit_algorithm=fit_algorithm,
transform_algorithm=transform_algorithm,
max_iter=100,
tol=1e-1,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this kind of test, we doesn't need good quality results

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lesteve lesteve merged commit 7d93ca8 into scikit-learn:main Apr 22, 2022
@lesteve
Copy link
Member
lesteve commented Apr 22, 2022

Merging thanks a lot!

jjerphan pushed a commit to jjerphan/scikit-learn that refe 8237 renced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:decomposition module:test-suite everything related to our tests No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0