TST Speed-up test_minibatch_dictionary_learning_dtype_match #23186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
commented
Apr 22, 2022
| @@ -911,9 +911,12 @@ def test_minibatch_dictionary_learning_dtype_match( | |||
| batch_size=10, | |||
| fit_algorithm=fit_algorithm, | |||
| transform_algorithm=transform_algorithm, | |||
| max_iter=100, | |||
There was a problem hiding this comment.
set max_iter to get the new behavior (old behavior doesn't have stopping criterion besides n_iter).
| @@ -911,9 +911,12 @@ def test_minibatch_dictionary_learning_dtype_match( | |||
| batch_size=10, | |||
| fit_algorithm=fit_algorithm, | |||
| transform_algorithm=transform_algorithm, | |||
| max_iter=100, | |||
| tol=1e-1, | |||
There was a problem hiding this comment.
for this kind of test, we doesn't need good quality results
|
Merging thanks a lot! |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test takes almost 1min to run locally. I can't imagine on azure. This PR makes it run in less than 2 secs.