10000 TST Fix ridge tests not deterministic by jeremiedbb · Pull Request #23181 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Fix ridge tests not deterministic #23181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2022
Merged

TST Fix ridge tests not deterministic #23181

merged 3 commits into from
Apr 21, 2022

Conversation

jeremiedbb
Copy link
Member

The ols_ridge_dataset fixture was missing calling make_low_rank_matrix with a fixed random_state. It's probably the cause of the non determinism we see when trying to run these tests for all random seeds.

Maybe the work done in #23026 was not necessary after all 😄. But I find it convenient still.

@jeremiedbb
missing random_state
683b1d9
@jeremiedbb
[all random seeds]
94c587c
@jeremiedbb
[all random seeds]
9819fd5 
test_ridge_regression
test_ridge_regression_hstacked_X
test_ridge_regression_vstacked_X
test_ridge_regression_unpenalized
test_ridge_regression_unpenalized_hstacked_X
test_ridge_regression_unpenalized_vstacked_X
test_ridge_regression_sample_weights
@jeremiedbb jeremiedbb mentioned this pull request Apr 21, 2022
Closed
This was referenced Apr 21, 2022
Open
Merged
lorentzenchr
lorentzenchr approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentzenchr lorentzenchr added the Quick Review For PRs that are quick to review label Apr 21, 2022
thomasjpfan
thomasjpfan approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit da78863 into scikit-learn:main Apr 21, 2022
@jeremiedbb jeremiedbb mentioned this pull request Apr 22, 2022
Closed
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
@jeremiedbb @jjerphan
TST Fix ridge tests not deterministic (scikit-learn#23181)
e20d96d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:linear_model No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @thomasjpfan @lorentzenchr
0